[PATCH] D74133: [compiler-rt] Build with correct ABI (PR38025)

[Riyaz V Puthiyapurayil via Phabricator via llvm-commits]

RVP added inline comments.


================
Comment at: compiler-rt/cmake/Modules/HandleCompilerRT.cmake:62
+    string(REPLACE "builtins" "${name}" LIBRARY_FILE "${LIBRARY_FILE}")
+    cache_compiler_rt_library(FALSE "${name}" "${target}" "${LIBRARY_FILE}")
   endif()
----------------
smeenai wrote:
> I don't think it's necessary to cache this one. The string replacement should be pretty cheap to recompute. That would also get you down to just one call to `cache_compiler_rt_library`, at which point you could just inline it.
Note that what is being cached is not string replacement, (I know that is cheap) but the file existence check (which is not as cheap). The caching also avoids printing the message to the output log which was one concern that @phosek raised.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74133/new/

https://reviews.llvm.org/D74133