[PATCH] D73600: [Matrix] Add remark propagation along the inlined-at chain.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 7 07:28:35 PST 2020


fhahn updated this revision to Diff 248930.
fhahn added a comment.

Add additional comments, fix some variable names.

In D73600#1852881 <https://reviews.llvm.org/D73600#1852881>, @anemet wrote:

> On the description: I would first explain what you do and then how to do, i.e. have "To motivate" and the example before the paragprah "For a given function, we traverse".


Sounds good, thanks. I'll re-order the paragraphs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73600/new/

https://reviews.llvm.org/D73600

Files:
  llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
  llvm/test/Transforms/LowerMatrixIntrinsics/remarks-inlining.ll
  llvm/test/Transforms/LowerMatrixIntrinsics/remarks.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73600.248930.patch
Type: text/x-patch
Size: 23214 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200307/7fac86c1/attachment.bin>


More information about the llvm-commits mailing list