[PATCH] D75796: [llvm-objdump][test] Reorganize ELF --syms tests

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 7 02:10:49 PST 2020


grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/symbol-table.test:6
+
+#      CHECK:SYMBOL TABLE:
+# CHECK-NEXT:0000000000001fff l     F .text	0000000000000000 local_func
----------------
Add a file/test comment?


================
Comment at: llvm/test/tools/llvm-objdump/ELF/symbol-table.test:40
+    Index:   SHN_ABS
+
+  - Name:    func
----------------
https://reviews.llvm.org/D75793#inline-690488


================
Comment at: llvm/test/tools/llvm-objdump/ELF/symbol-table.test:68
+
+## %08x is used to print the address and size fields of an ELF32 object.
+# RUN: yaml2obj --docnum=2 -D BITS=32 %s -o %t.32
----------------
I'd replace `%08x` with words. I.e. "we print addresses as 32 bit values" or alike. 
(It is not really important how exactly this logic is implemented, with `%08x` or something different).



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75796/new/

https://reviews.llvm.org/D75796





More information about the llvm-commits mailing list