[PATCH] D75590: [Attributor] IPO across definition boundary of a function marked alwaysinline

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

I think this is all good, two minor comments below. Once fixed I commit it



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:641
+  /// Set of inlineable functions
+  SmallPtrSet<Function *, 8> InlineableFunctions;
+
----------------
make it const function, and appropriate below.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:804
+        return true;
+      return false;
+    }
----------------
Nit: `return InfoCache.InlineableFunctions.count(&F)` (no braces)
or even:
`return F.hasExactDefinition() || InfoCache.InlineableFunctions.count(&F);`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75590/new/

https://reviews.llvm.org/D75590