[PATCH] D75793: [llvm-objdump] --syms: print 'i' for STT_GNU_IFUNC
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 6 20:55:05 PST 2020
MaskRay updated this revision to Diff 248891.
MaskRay added a comment.
Herald added a subscriber: emaste.
Herald added a reviewer: espindola.
Rebase on D75796 <https://reviews.llvm.org/D75796>
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75793/new/
https://reviews.llvm.org/D75793
Files:
llvm/test/tools/llvm-objdump/ELF/symbol-table.test
llvm/tools/llvm-objdump/llvm-objdump.cpp
Index: llvm/tools/llvm-objdump/llvm-objdump.cpp
===================================================================
--- llvm/tools/llvm-objdump/llvm-objdump.cpp
+++ llvm/tools/llvm-objdump/llvm-objdump.cpp
@@ -1896,6 +1896,10 @@
bool Absolute = Flags & SymbolRef::SF_Absolute;
bool Common = Flags & SymbolRef::SF_Common;
bool Hidden = Flags & SymbolRef::SF_Hidden;
+ char Indirect = ' ';
+ if (auto *ELF = dyn_cast<ELFObjectFileBase>(O))
+ if (ELFSymbolRef(*I).getELFType() == ELF::STT_GNU_IFUNC)
+ Indirect = 'i';
char GlobLoc = ' ';
if ((Section != O->section_end() || Absolute) && !Weak)
@@ -1918,7 +1922,7 @@
<< (Weak ? 'w' : ' ') // Weak?
<< ' ' // Constructor. Not supported yet.
<< ' ' // Warning. Not supported yet.
- << ' ' // Indirect reference to another symbol.
+ << Indirect // Indirect reference to another symbol.
<< Debug // Debugging (d) or dynamic (D) symbol.
<< FileFunc // Name of function (F), file (f) or object (O).
<< ' ';
Index: llvm/test/tools/llvm-objdump/ELF/symbol-table.test
===================================================================
--- llvm/test/tools/llvm-objdump/ELF/symbol-table.test
+++ llvm/test/tools/llvm-objdump/ELF/symbol-table.test
@@ -12,7 +12,7 @@
# CHECK-NEXT:0000000000000000 *UND* 0000000000000000 undef
# CHECK-NEXT:0000000000000000 g *ABS* 0000000000000000 abs
# CHECK-NEXT:0000000000000000 *COM* 0000000000000000 common
-# CHECK-NEXT:0000000000000000 g .text 0000000000000000 ifunc
+# CHECK-NEXT:0000000000000000 g i .text 0000000000000000 ifunc
# CHECK-NEXT:0000000000000000 g O .data 0000000000000000 gnu_unique
--- !ELF
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75793.248891.patch
Type: text/x-patch
Size: 1762 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200307/1d799ac3/attachment.bin>
More information about the llvm-commits
mailing list