[PATCH] D75785: Add support for SHA256 source file checksums in debug info

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Sounds reasonable. One inline question about the test.



================
Comment at: llvm/test/Bitcode/upgrade-dbg-checksum.ll:13
+!3 = distinct !DICompileUnit(language: DW_LANG_C99, file: !7, producer: "clang version 5.0.1 (tags/RELEASE_501/final)", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug)
+!4 = distinct !DICompileUnit(language: DW_LANG_C99, file: !8, producer: "clang version 5.0.1 (tags/RELEASE_501/final)", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug)
 ; CHECK: !DIFile(filename: "a.c", directory: "/test")
----------------
I would expect a round-trip (as | dis | as |dis) test rather than an upgrade test when adding an extra enumerator. What am I missing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75785/new/

https://reviews.llvm.org/D75785