[PATCH] D75777: Fix a copy and paste error that would cause a crash.

[Greg Clayton via Phabricator via llvm-commits]

clayborg created this revision.
clayborg added a reviewer: aprantl.
Herald added a reviewer: JDevlieghere.
Herald added a project: LLVM.
clayborg added a reviewer: friss.

The wrong variable was being checked for an error, which mean a llvm::Error went unchecked and crashes dsymutil. Discovered this when trying to feed an ELF file to "dsymutil --update" and running into the crash.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75777

Files:
  llvm/tools/dsymutil/MachODebugMapParser.cpp


Index: llvm/tools/dsymutil/MachODebugMapParser.cpp
===================================================================
--- llvm/tools/dsymutil/MachODebugMapParser.cpp
+++ llvm/tools/dsymutil/MachODebugMapParser.cpp
@@ -383,7 +383,7 @@
 
   auto Objects = ObjectEntry->getObjectsAs<MachOObjectFile>();
   if (!Objects) {
-    return errorToErrorCode(ObjectEntry.takeError());
+    return errorToErrorCode(Objects.takeError());
   }
 
   std::vector<std::unique_ptr<DebugMap>> Results;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75777.248843.patch
Type: text/x-patch
Size: 484 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200306/ce83f416/attachment.bin>