[PATCH] D74749: ThinLTOBitcodeWriter: drop dso_local when a GlobalVariable is converted to a declaration

Fri Mar 6 14:23:02 PST 2020

hoyFB added a comment.

In D74749#1910352 <https://reviews.llvm.org/D74749#1910352>, @MaskRay wrote:

> In D74749#1910258 <https://reviews.llvm.org/D74749#1910258>, @hoyFB wrote:
>
> > Hello, It looks like this change is breaking the test llvm/test/tools/gold/X86/thinlto_weak_library.ll . Can you please verify? Thanks!
>
>
> My other llvm-objdump -d change also caused a disassembly test to fail.
>
> Fixed by c3de1d0b1f99926f4a2665756b29b2d35a8359b8 <https://reviews.llvm.org/rGc3de1d0b1f99926f4a2665756b29b2d35a8359b8>

Thanks for the fast turnaround!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74749/new/

https://reviews.llvm.org/D74749