[PATCH] D72828: [DWARF5] Added support for emission of debug_macro section.
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 6 13:15:51 PST 2020
probinson added a comment.
In D72828#1908583 <https://reviews.llvm.org/D72828#1908583>, @SouraVX wrote:
> In D72828#1907639 <https://reviews.llvm.org/D72828#1907639>, @ikudrin wrote:
>
> > While this can be applied to `master` cleanly, it cannot be built, because it requires D73086 <https://reviews.llvm.org/D73086>; it applies after D73086 <https://reviews.llvm.org/D73086> with some conflicts. Please, prepare a diff which will be applied after D73086 <https://reviews.llvm.org/D73086> cleanly and add D73086 <https://reviews.llvm.org/D73086> as a parent revision to show the dependency.
>
>
> Hi @ikudrin and other reviewers, How about committing `Dwarf.def` and `Dwarf.h` changes/Mostly Flag encodings/ and stringify encoding functionalties as separate commit. That will resolve most of false dependencies. In my opinion that part adding those flags and encoding is independent of these patches(for instance, most of other encodings/flags described by dwarfv5 spec are their, even when LLVM/consumer might not be using them at present) and should be committed separately.
> Any thoughts on this?
That would be perfectly fine.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72828/new/
https://reviews.llvm.org/D72828
More information about the llvm-commits
mailing list