[PATCH] D75769: [mlir][nfc] Fix building mlir_c_runner_utils for Windows

[Kern Handa via Phabricator via llvm-commits]

kernhanda created this revision.
kernhanda added reviewers: nicolasvasilache, ftynse, mehdi_amini.
Herald added subscribers: llvm-commits, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, burmako, jpienaar, rriddle.
Herald added a project: LLVM.
kernhanda added a comment.

This will need to be committed on my behalf.


On Windows, building `mlir_c_runner_utils` doesn't properly export
symbols, thus resulting in an implib not being created, which causes
an error when consuming LLVM from external projects.

Authors: Mason Remy <masonremy at gmail.com>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75769

Files:
  mlir/include/mlir/ExecutionEngine/CRunnerUtils.h
  mlir/lib/ExecutionEngine/CRunnerUtils.cpp


Index: mlir/lib/ExecutionEngine/CRunnerUtils.cpp
===================================================================
--- mlir/lib/ExecutionEngine/CRunnerUtils.cpp
+++ mlir/lib/ExecutionEngine/CRunnerUtils.cpp
@@ -12,6 +12,8 @@
 //
 //===----------------------------------------------------------------------===//

+#include "mlir/ExecutionEngine/CRunnerUtils.h"
+
 #include <cinttypes>
 #include <cstdio>

Index: mlir/include/mlir/ExecutionEngine/CRunnerUtils.h
===================================================================
--- mlir/include/mlir/ExecutionEngine/CRunnerUtils.h
+++ mlir/include/mlir/ExecutionEngine/CRunnerUtils.h
@@ -167,6 +167,8 @@
 //===----------------------------------------------------------------------===//
 // Small runtime support "lib" for vector.print lowering during codegen.
 //===----------------------------------------------------------------------===//
+extern "C" MLIR_CRUNNERUTILS_EXPORT void print_i32(int32_t i);
+extern "C" MLIR_CRUNNERUTILS_EXPORT void print_i64(int64_t l);
 extern "C" MLIR_CRUNNERUTILS_EXPORT void print_f32(float f);
 extern "C" MLIR_CRUNNERUTILS_EXPORT void print_f64(double d);
 extern "C" MLIR_CRUNNERUTILS_EXPORT void print_open();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75769.248810.patch
Type: text/x-patch
Size: 1203 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200306/e6afcbbe/attachment.bin>