[PATCH] D75722: [mlir][Linalg] Implement padding for linalg.conv and lowering to loops.

[Han-Chung Wang via Phabricator via llvm-commits]

hanchung added inline comments.


================
Comment at: mlir/lib/Dialect/Linalg/Transforms/LinalgToLoops.cpp:178
 public:
+  static ValueHandle getConvOpInput(ConvOp convOp, IndexedValueType I,
+                                    ArrayRef<ValueHandle> imIdx) {
----------------
mravishankar wrote:
> Could you add some comments about whats happening here?
Done.


================
Comment at: mlir/lib/Dialect/Linalg/Transforms/LinalgToLoops.cpp:206
+
+      assert(shapes[idx] != -1 && "dynamic shape is not available");
+      ValueHandle shape = std_constant_index(shapes[idx]);
----------------
mravishankar wrote:
> I am not sure we need to restrict this for the static shape case. You can always get the dimension dynamically and generate code for that. Just generate a dim operation?
Done.
Yes, you're right, we can always get the dimension here. Also change the tests to dynamic shape.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75722/new/

https://reviews.llvm.org/D75722