[PATCH] D75278: Use FileDescriptorIsDisplayed in place of direct call to isatty in support library
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 6 11:35:46 PST 2020
MaskRay added a comment.
Thank you for the clarification in D75707 <https://reviews.llvm.org/D75707>. I hoped the summary did not beat the bush...
I know any suggestion on this topic may be belated.. but you could simply do
int isatty(int fd) {
return 0;
}
in your libc. If you enable Identical Code Folding, it may have 0 size cost after stripping.
LGTM once you made it clear in the code and the summary.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75278/new/
https://reviews.llvm.org/D75278
More information about the llvm-commits
mailing list