[PATCH] D75145: [PassManager] adjust VectorCombine placement

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D75145#1910129 <https://reviews.llvm.org/D75145#1910129>, @spatel wrote:

> In D75145#1910117 <https://reviews.llvm.org/D75145#1910117>, @lebedev.ri wrote:
>
> > @dmgreen i expect that regression to have been fixed by rG1badf7c33a5d01900c77646f750e2ea11ad8bf5a <https://reviews.llvm.org/rG1badf7c33a5d01900c77646f750e2ea11ad8bf5a>, please confirm.
> >  Please do post more findings, if there are any.
>
>
> Oops...you're moving faster than me or my email inbox, so disregard my earlier question. :)


:)

> I'd still like to understand if we have the ideal ARM output now.

Look/compare `-analyze -scalar-evolution` output:
https://godbolt.org/z/XvgSua

- first source is before *this patch*
- second is after this patch, we clearly regress
- and the last is after my fix, we're back to the original

> And maybe we can add a test to PhaseOrdering based on that ARM example, so we have coverage for the larger case.

Yes, feel free to.

> Also, we may still have other problems as noted by @bjope .

Yep, waiting for more examples.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75145/new/

https://reviews.llvm.org/D75145