[PATCH] D70557: [lld][COFF] Add support for /map

[Sylvain Audi via Phabricator via llvm-commits]

saudi marked 5 inline comments as done.
saudi added inline comments.


================
Comment at: lld/COFF/MapFile.cpp:76-77
+    // This can happen with symbols of Absolute kind
+    uint64_t rvaa = config->imageBase + a.first->getRVA();
+    uint64_t rvab = config->imageBase + b.first->getRVA();
+    return rvaa < rvab || (rvaa == rvab && a.second < b.second);
----------------
ruiu wrote:
> If you are adding `config->imageBase` to both A and B before comparing A < B, you don't have to add that at all, do you?
This was to support underflowing that happens with DefinedAbsolute symbols (RVA = VA - imageBase).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70557/new/

https://reviews.llvm.org/D70557