[PATCH] D70557: [lld][COFF] Add support for /map

Sylvain Audi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 6 10:29:05 PST 2020


saudi updated this revision to Diff 248777.
saudi marked an inline comment as done.
saudi added a comment.

Implemented the fixes suggested by Rui Ueyama.

Notes on the timestamp:
I replaced the strftime call with a local implementation that reproduces what link.exe outputs.
Assuming link.exe was built using MSVC, I suspect that its implementation uses strftime("%c"), as it matches the format from Visual C++'s CRT library using the "C" locale.
I couldn't find a way on my machine to have link.exe output differently : my machine is configured as French, but link.exe's /map outputs  english message (e.g. "Fri Mar  6 11:50:39 2020").


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70557/new/

https://reviews.llvm.org/D70557

Files:
  lld/COFF/CMakeLists.txt
  lld/COFF/Config.h
  lld/COFF/Driver.cpp
  lld/COFF/LLDMapFile.cpp
  lld/COFF/LLDMapFile.h
  lld/COFF/MapFile.cpp
  lld/COFF/Options.td
  lld/COFF/Writer.cpp
  lld/test/COFF/Inputs/map.yaml
  lld/test/COFF/lldmap.test
  lld/test/COFF/map.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70557.248777.patch
Type: text/x-patch
Size: 26775 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200306/788c9e0d/attachment.bin>


More information about the llvm-commits mailing list