[PATCH] D75633: [hwasan_symbolize] Make hwasan_symbolize compatible with Android fuzzing out-of-box.

Fri Mar 6 09:54:13 PST 2020

hctim abandoned this revision.
hctim marked an inline comment as done.
hctim added inline comments.

================
Comment at: compiler-rt/lib/hwasan/scripts/hwasan_symbolize:204
+    # The Android fuzzing `/data/fuzz` out directory contains executables with
+    # symbols.
+    binary_prefixes.append(os.environ['ANDROID_PRODUCT_OUT'])
----------------
eugenis wrote:
> It's not about /data/fuzz specifically. Maybe say that we fallback to $ANDROID_PRODUCT_OUT if the binary can not be found under "symbols" because some targets (ex. fuzzers) install unstripped binaries to the device.
> 
> Is this something that should be (could be?) fixed on the Android side? It's the common convention to put unstripped binaries under symbols. Ex. apex generation goes to great lengths to set up paths under symbols/ to match runtime mount path of the apex on device.
Yeah, agreed. Symbol reexporting available here: https://android-review.googlesource.com/c/platform/build/soong/+/1252144

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75633/new/

https://reviews.llvm.org/D75633