[PATCH] D75631: [test] Fix reliability of disassemble-functions.test

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added a comment.

In D75631#1909084 <https://reviews.llvm.org/D75631#1909084>, @jhenderson wrote:

> @MaskRay just made a change to some disassembly output (see D75713 <https://reviews.llvm.org/D75713>). I'm not sure if it's going to impact this change or not, but you should check. Also, could you clarify what you mean by "sometimes disassembled" please? Why does it change?


I'm not sure why does it change since I've only seen dump from the CI and haven't been able to reproduce the failure locally. However the dump I get shows "callq </tmp/a.c>" which seems like an arbitrary choice (it's not the first symbol for that address, it's a STT_FILE instead of STT_FUNC). Also if anything the right output should be callq <foo> which would fail with the current --implicit-check-not. I've updated it to use <foo>: instead of "foo:" given the D75713 <https://reviews.llvm.org/D75713> change you pointed at. By the way it makes me wonder if there isn't some CHECK-NOT or implicit check not relying on the old output which are never going to be triggered even if the output goes wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75631/new/

https://reviews.llvm.org/D75631