[PATCH] D74443: [lld][Hexagon] convert call x at GDPLT to call __tls_get_addr

[via llvm-commits]

I got clang-tidy formatting errors using some of the suggested variable
names, I "fixed" them between diff 6 and 7.
https://reviews.llvm.org/D74443?vs=247249&id=247345&whitespace=ignore-most#t
oc

outputSections->OutputSections, isec->Isec, sym->Sym etc

> -----Original Message-----
> From: Fangrui Song via Phabricator <reviews at reviews.llvm.org>
> Sent: Thursday, March 5, 2020 5:54 PM
> To: sidneym at codeaurora.org; maskray at google.com;
> shankare at codeaurora.org; bcain at codeaurora.org; kparzysz at quicinc.com
> Cc: jyknight at google.com; emaste at freebsd.org;
> arichardson.kde at gmail.com; fedor.sergeev at azul.com; llvm-
> commits at lists.llvm.org
> Subject: [PATCH] D74443: [lld][Hexagon] convert call x at GDPLT to call
> __tls_get_addr
> 
> MaskRay added a comment.
> 
> Many variable names are still not fixed.
> 
> 
> 
> ================
> Comment at: lld/ELF/Relocations.cpp:1985
> +bool HexagonNeedsTLSSymbol(ArrayRef<OutputSection *>
> outputSections) {
> +  bool NeedTLSSymbol = false;
> +  forEachInputSectionDescription(
> ----------------
> MaskRay wrote:
> > lld uses `variableName`
> Not done. `os` `isd`
> 
> 
> ================
> Comment at: lld/ELF/Relocations.cpp:1982
> +// hexagonTLSSymbolUpdate rebinds the relocation to __tls_get_addr.
> +bool hexagonNeedsTLSSymbol(ArrayRef<OutputSection *>
> OutputSections) {
> +  bool NeedTlsSymbol = false;
> ----------------
> `outputSections`
> 
> 
> ================
> Comment at: lld/ELF/Relocations.cpp:1983
> +bool hexagonNeedsTLSSymbol(ArrayRef<OutputSection *>
> OutputSections) {
> +  bool NeedTlsSymbol = false;
> +  forEachInputSectionDescription(
> ----------------
> `needTlsSymbol`
> 
> 
> ================
> Comment at: lld/ELF/Relocations.cpp:1996
> +
> +void hexagonTLSSymbolUpdate(ArrayRef<OutputSection *>
> OutputSections) {
> +  bool NeedEntry = true;
> ----------------
> `outputSections`
> 
> 
> ================
> Comment at: lld/test/ELF/hexagon-tls-gd-xform.s:38
> +# RELA_GDPLT-NEXT  Section (5) .rela.plt {
> +# RELA_GDPLT-NEXT    0x30298 R_HEX_JMP_SLOT x 0x0
> +# RELA_GDPLT-NEXT    0x3029C R_HEX_JMP_SLOT __tls_get_addr 0x0
> ----------------
> Without a colon, these checks are not effective.
> 
> 
> Repository:
>   rG LLVM Github Monorepo
> 
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D74443/new/
> 
> https://reviews.llvm.org/D74443
> 
>