[PATCH] D75114: [DAG] MatchRotate - Add funnel shift by immediate support

[Krzysztof Parzyszek via Phabricator via llvm-commits]

kparzysz added a comment.

The Hexagon changes LGTM.



================
Comment at: llvm/lib/Target/Hexagon/HexagonPatterns.td:1098
   def: Pat<(fshl I32:$Rs, I32:$Rt, (i32 16)),
-           (A2_combine_hl I32:$Rs, I32:$Rt)>;
+           (A2_combine_hl I32:$Rs, I32:$Rt)>; // A2_combine_lh?
   def: Pat<(fshl I64:$Rs, I64:$Rt, IsMul8_U3:$S),
----------------
RKSimon wrote:
> @kparzysz Any comments on this? Should I split off a patch with a fshl specific test case?
You are correct.  This should be `A2_combine_lh`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75114/new/

https://reviews.llvm.org/D75114