[PATCH] D75733: Extract common code to deal with multidimensional vectors.

[Adrian Kuegel via Phabricator via llvm-commits]

akuegel added inline comments.


================
Comment at: mlir/lib/Conversion/StandardToLLVM/ConvertStandardToLLVM.cpp:1169
 
+template <unsigned OpCount>
+static bool HandleMultidimensionalVectors(
----------------
ftynse wrote:
> Is it really worth it to add a template (and hence increase compile time and binary size) only to forward it to `SmallVector`? I'd just use `4` instead, this should cover the vast majority of cases.
Actually I first did exactly that but then thought maybe I shouldn't introduce an actual change with this CL. But I completely agree with you, so changed it to SmallVector with constant 4.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75733/new/

https://reviews.llvm.org/D75733