[PATCH] D75145: [PassManager] adjust VectorCombine placement

Fri Mar 6 04:57:39 PST 2020

spatel added a comment.

In D75145#1909324 <https://reviews.llvm.org/D75145#1909324>, @bjope wrote:

> When you say "phase ordering bug" that is about not generating as optimized code as expected, right? Not ending up with miscompiles (or compiler crashes)?
>
> (just curious since we got regressions downstream after this patch... haven't looked deeper at that and it could just be some limitations in our backend, but could be nice to know if it is "safe" for us to revert this downstream while investigating)

Yes, this patch is only about getting more optimized code through the opt pipeline.

Other than this problem:
D75327 <https://reviews.llvm.org/D75327>
...I don't know of VectorCombine causing miscompiles/crashing.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75145/new/

https://reviews.llvm.org/D75145