[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX marked an inline comment as done.
SouraVX added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp:88
       M->Offset = Offset;
+      if (Context.getMaxVersion() >= 5) {
+        Expected<bool> Status = M->Header.parseMacroHeader(data, &Offset);
----------------
ikudrin wrote:
> This prevents parsing .debug_macinfo sections if an input file has a mix of debugging information with different versions. The parsing method should explicitly distinct two kinds of macro section. Maybe it will be more clear if there are two distinct parsing methods.
The fact that we're inclined to re-use/represent macro information with existing infra(macinfo) + some shared enodings(different names) is causing some of these issues.
But separating them we'll loose code-reuse and possibly other things?
Anyways, if you have any ideas/thoughts on this please share!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086