[PATCH] D75600: Add nullptr check to isLandingPad

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 6 03:18:33 PST 2020


fhahn added a comment.

Hm I think calling isLandingPad on an empty (=invalid) basic block might be a pre-condition violation we legitimately want to crash on (with assertions isa<> assert != 0)?  I suspect there are a lot of functions that expect BBs with at least a valid terminator and would crash for empty basic blocks. Unless I am missing something I think it might be better to avoid calling it on invalid block in the client code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75600/new/

https://reviews.llvm.org/D75600





More information about the llvm-commits mailing list