[PATCH] D75679: [yaml2obj][obj2yaml][Object][test] - Improve testing of relocation types.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Some nits. Otherwise, LGTM.



================
Comment at: llvm/test/tools/obj2yaml/relocation-type.yaml:4
+## Show that obj2yaml is able to dump relocation types when `e_machine` kind is unknown.
+
+# RUN: yaml2obj %s -o %t1 -DMACHINE=0x1234
----------------
Probably should delete this and the similar blank lines after the later case comments in this and the other test. At the moment, it's not clear that it's tied to this test case.


================
Comment at: llvm/test/tools/obj2yaml/relocation-type.yaml:46
+    Relocations:
+## Test a few noticable possible values: 0, 1, max(int8_t)=127, max(uint8_t)=0xFF=-1
+      - Offset: 0x9
----------------
noticable -> noticeable


================
Comment at: llvm/test/tools/yaml2obj/ELF/relocation-type.yaml:9
+# CHECK: Relocation section '.rela.text' at offset 0x40 contains 4 entries:
+# CHECK:      Offset            Info             Type    Symbol's Value  Symbol's Name + Addend
+# CHECK-NEXT: 0000000000000009  0000000000000000 [[FIRST]]                               0
----------------
You can get rid of the column names for the bits we aren't testing below.


================
Comment at: llvm/test/tools/yaml2obj/ELF/relocation-type.yaml:30
+    Relocations:
+## Test a few noticable possible values: 0, 1, max(int8_t)=127, max(uint8_t)=0xFF=-1
+      - Offset: 0x9
----------------
noticeable


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75679/new/

https://reviews.llvm.org/D75679