[PATCH] D75536: [LLD] Add support for --unique option

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: lld/ELF/Config.h:197
   bool undefinedVersion;
+  bool unique = false;
   bool useAndroidRelrTags = false;
----------------
davidb wrote:
> MaskRay wrote:
> > Delete `= false`
> Why do you not want me to be explicit here? Many other options above are
There is a difference. Look at `sysvHash` for example whitch is explicitly set to `false`.
`sysvHash` is not always set to something in the code. Hence we have to initialize it.

You always assing `unique`: `config->unique = args.hasArg(OPT_unique);`. So no need to initialize it explicitly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75536/new/

https://reviews.llvm.org/D75536