[PATCH] D75314: [mlir] Add a new BranchOpInterface to allow for opaquely interfacing with branching terminator operations.
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 5 23:30:50 PST 2020
rriddle added a comment.
In D75314#1908993 <https://reviews.llvm.org/D75314#1908993>, @stephenneuendorffer wrote:
> This commit introduces a circular library dependence with the dialects.
Yes thanks, all of the interfaces in analysis are going to be moved out of Analysis in a followup.
> Can this be part of the Standard dialect instead,
It doesn't really make sense to put an interface definition inside of a specific dialect.
> or maybe lib/IR if it is fundamental?
IR/ should be kept clean, otherwise it will become a dumping ground for interfaces(like it is for traits ATM unfortunately).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75314/new/
https://reviews.llvm.org/D75314
More information about the llvm-commits
mailing list