[PATCH] D75485: Support DW_FORM_strx* in llvm-dwp.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX added a comment.

In D75485#1908830 <https://reviews.llvm.org/D75485#1908830>, @tamur wrote:

> In D75485#1908787 <https://reviews.llvm.org/D75485#1908787>, @dblaikie wrote:
>
> > Ah, looks like this overlaps a bit with https://reviews.llvm.org/D74312 - might be worth checking there if there's any necessary issues (rather than orthogonal pieces) that patch addresses that this one doesn't, etc.
>
>
> Thank you, I was not aware https://reviews.llvm.org/D74312 ; I looked at it, yes it seems this patch and that mostly solves the same problems; it seems parts of that patch have already been checked in (maybe as another patch?) but other parts have not seen action for some time. I added the author @SouraVX as a reviewer for comment.


Hi thanks for doing this, I was occupied by my other reviews so the debug_str_offsets changes didn't went in. D74425 <https://reviews.llvm.org/D74425> only addresses info section(Mostly the changes in Header) parsing and writing to dwp.
BTW, have you tested the resultant dwp for debuggability with GDB ?? I also tried to apply locally D74312 <https://reviews.llvm.org/D74312>(info + str_offsets support), As I recall loading of dwp was fine. But their were some complaints reported when you try running/set break etc. If possible can you confirm this ?

Your changes LGTM! but you can wait for @dblaikie comments/approval.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75485/new/

https://reviews.llvm.org/D75485