[PATCH] D70720: [llvm-objdump] Display locations of variables alongside disassembly

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard marked 3 inline comments as done.
ostannard added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/ARM/debug-vars-dwarf4.s:91
+# LINE-NUMS: 00000000 foo:
+# LINE-NUMS-NEXT: ; SRC_COMPDIR{{[/\\]}}debug.c:2                                           ┠─ a = R0
+# LINE-NUMS-NEXT:                                                                   ┃ ┠─ b = R1
----------------
jhenderson wrote:
> Will this ever be "\\"? The SRC_COMPDIR sed pattern explicitly uses '/' now.
The SRC_COMPDIR sed script isn't used for the LINE-NUMS test (if it was we'd then need to regex out the whole path), so I've put this regex back.


================
Comment at: llvm/test/tools/llvm-objdump/ARM/debug-vars-wide-chars.s:10
+# CHECK: 00000000 foo:
+# CHECK-NEXT: ;   return *喵;                                                                 ┠─ 喵 = R0
+# CHECK-NEXT:       0: 00 00 90 e5                  	ldr	r0, [r0]                        ┻
----------------
jhenderson wrote:
> I think it will, but will this work on Windows (non-UTF8 environment)?
It turns out that this doesn't work, at least in my windows 10 VM, so I'll disable this test for windows.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70720/new/

https://reviews.llvm.org/D70720