[PATCH] D75499: [cmake] By default do not build compiler-rt with PGO instrumentation or use

Rong Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 5 15:53:48 PST 2020


xur accepted this revision.
xur added a comment.
This revision is now accepted and ready to land.

One correction to my previous comment: the default of NOT COMPILER_RT_ENABLE_PGO is true. But I think it's OK, as far as we have a way to build the instrumented version of compiler_rt.

Please do indicate this (the change of default behavior) in your commit message.

This patch looks good to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75499/new/

https://reviews.llvm.org/D75499





More information about the llvm-commits mailing list