[PATCH] D75305: [AIX] Handle LinkOnceODRLinkage and llvm.global_ctors/dtors' AppendingLinkage
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 5 15:53:45 PST 2020
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.
LGTM with minor comment.
================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1597
+ // TODO: Update the handling of global arrays for static init when we support
+ // the ".ref" directive.
+ if (isSpecialLLVMGlobalArrayForStaticInit(GV))
----------------
Suggestion to add a second sentence:
Otherwise, we can skip these arrays, because the AIX linker collects these functions simply based on their name.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75305/new/
https://reviews.llvm.org/D75305
More information about the llvm-commits
mailing list