[PATCH] D74691: [Attributor] Detect possibly unbounded cycles in functions
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 5 15:21:41 PST 2020
jdoerfert added a comment.
High level comments:
- Please do not use global variables. If you need a set/map, create it on the stack and pass it as a reference.
- If the algorithm to distinguish cycles and loops makes problems, we can just go through all loops in loop info and verify there is no irreducible control (see for example `mayContainIrreducibleControl` in `MustExecute.cpp`)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74691/new/
https://reviews.llvm.org/D74691
More information about the llvm-commits
mailing list