[PATCH] D75653: [mlir][LLVM] Introduce an intrinsic for llvm.matrix.multiply

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache added inline comments.


================
Comment at: mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td:797
+      Arguments<(
+        ins LLVM_Type:$A, LLVM_Type:$B, I32Attr:$M, I32Attr:$N, I32Attr:$K)> {
+  string llvmBuilder = [{
----------------
ftynse wrote:
> ftynse wrote:
> > Could have at least have a textual description to understand what ABMNK mean? These will be the names of accessor functions as well...
> Also, any reason to chose I32 attribute?
to match the LLVM impl: https://reviews.llvm.org/D70456


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75653/new/

https://reviews.llvm.org/D75653