[PATCH] D75646: Add an SDK attribute to DICompileUnit
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 5 14:17:19 PST 2020
dblaikie added a comment.
Mechanically seems fine (though probably/I think these sort of things should be committed in three parts - IR support, frontend usage, backend usage - but nice to review in one piece like this). I'll defer actual detailed review/sign-off to at least someone else with a vested interest in this features usage just to make sure it's got some in-review... review :)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75646/new/
https://reviews.llvm.org/D75646
More information about the llvm-commits
mailing list