[PATCH] D68063: Propeller: LLVM support for basic block sections

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 5 13:12:31 PST 2020


efriedma added a comment.

I'm not completely comfortable passing the BB-sections list to the backend as a file path; generally we try to allow the "frontend" (clang/llc/etc.) to control all file I/O.  But I'm not sure what the alternative looks like.  I guess we could pass it as MemoryBuffer?

Otherwise looks fine.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68063/new/

https://reviews.llvm.org/D68063





More information about the llvm-commits mailing list