[PATCH] D75278: Use FileDescriptorIsDisplayed in place of direct call to isatty in support library

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 5 12:07:06 PST 2020


MaskRay added a comment.

System V Release 4 had isatty and isatty is in POSIX.1-2001 includes isatty. Which OS are your porting to? (Not necessarily an objection, but I am slightly concerned of we may see many future subtle changes like this.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75278/new/

https://reviews.llvm.org/D75278





More information about the llvm-commits mailing list