[PATCH] D75536: [LLD] Add support for --unique option

Dave Bozier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 5 10:22:49 PST 2020


davidb marked 3 inline comments as done.
davidb added inline comments.


================
Comment at: lld/ELF/Config.h:197
   bool undefinedVersion;
+  bool unique = false;
   bool useAndroidRelrTags = false;
----------------
MaskRay wrote:
> Delete `= false`
Why do you not want me to be explicit here? Many other options above are


================
Comment at: lld/ELF/Driver.cpp:970
   config->sysroot = args.getLastArgValue(OPT_sysroot);
+  config->unique = args.hasArg(OPT_unique);
   config->target1Rel = args.hasFlag(OPT_target1_rel, OPT_target1_abs, false);
----------------
MaskRay wrote:
> lexicographical order
was result of rebase


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75536/new/

https://reviews.llvm.org/D75536





More information about the llvm-commits mailing list