[PATCH] D75511: [APFloat] Remove neg in favour of unary operator-

Ehud Katz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 5 09:50:49 PST 2020


ekatz added a comment.

It is a matter of taste. I actually see the benefits of the clear code when using operator overloads.
The question is, should we remove the explicit function calls?
Lets say we do; I still prefer (above all) a unified coding style. In this case, it interprets as: //removing all the other operators//. The problem is, with `add` (for example). It receives a `roundingMode` as a parameter, which means that we can't remove this function, in exchange to the `operator+`. We must maintain both.
So, to maintain consistency, I think we should keep `neg` as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75511/new/

https://reviews.llvm.org/D75511





More information about the llvm-commits mailing list