[PATCH] D75647: [llvm-readobj] Include section name of notes.

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:6278
+    if (SecName)
+      W.printString("Name", *SecName);
     W.printHex("Offset", Offset);
----------------
grimar wrote:
> Should we always print fields? (i.e. print `Name=something` for `!SecName`).
> Is it the only case for LLVM output where we can omit/print field I guess?
> (I remember we had something like this before somewhere and removed it).
Yes, we do have a custom of printing `<?>` for unknown sections/symbols. Updated here, but not for GNU output format, for better compatibility.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75647/new/

https://reviews.llvm.org/D75647