[PATCH] D75175: [CallSiteInfo] Enable the call site info only for -g + optimizations

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/CommandFlags.inc:280
+    "emit-call-site-info",
+    cl::desc("Emit call site info. Currently, it is only used for debug info "
+             "in optimized code, so it will be enabled only in the case of "
----------------
Let's not use a wording like `Currently`, it will start looking awkward soon.

`"Emit call site debug information, if debug information is enabled."`


================
Comment at: llvm/include/llvm/CodeGen/CommandFlags.inc:282
+             "in optimized code, so it will be enabled only in the case of "
+             "'-g' + 'O>0' level."),
+    cl::init(false));
----------------
Again, this text can't be in LLVM since it is Clang's decision when to enable this. (At least I'm assuming that it is Clang :-). A different fronted could conceivably make different choices.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75175/new/

https://reviews.llvm.org/D75175