[PATCH] D75527: [yaml2obj] - Add `ELFYAML::YAMLInt` to fix how we parse a relocation `Addend` key.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 5 07:08:26 PST 2020


jhenderson added a comment.

In D75527#1907531 <https://reviews.llvm.org/D75527#1907531>, @grimar wrote:

>   I am not strongly against the idea to print them as unsigned hex numbers, but FTR:
>   
>
> In D75527#1907129 <https://reviews.llvm.org/D75527#1907129>, @jhenderson wrote:
>
> > I think obj2yaml should print as unsigned hex numbers, since that is what is displayed by tools such as llvm-readelf.
>
>
> But not GNU readelf. See "FIXME" in D75671 <https://reviews.llvm.org/D75671>: llvm-readelf -r displays decimal addends.


Apparently my memory is playing tricks on me. llvm-readobj displays unsigned hex.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75527/new/

https://reviews.llvm.org/D75527





More information about the llvm-commits mailing list