[PATCH] D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR

Thu Mar 5 03:51:47 PST 2020

kiranchandramohan marked 4 inline comments as done.
kiranchandramohan added a comment.

Thanks for the reviews. Committing with changes suggested.

================
Comment at: mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:379

+  if (opInst.getDialect() ==
+      opInst.getContext()->getRegisteredDialect<omp::OpenMPDialect>()) {
----------------
rriddle wrote:
> When adding more OMP operations(i.e. in a followup) can we split translating these operations into a different function? This one is already getting quite large.
Will move to a new function for the next operation.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72962/new/

https://reviews.llvm.org/D72962