[PATCH] D75608: [lib/ObjectYAML] - Make `ELFYAML::Relocation::Offset` optional.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 5 02:46:34 PST 2020


jhenderson added a comment.

I don't have any strong opinion on this. I personally would be slightly confused not seing an Offset printed by obj2yaml for one of the relocations, but I'm okay with it if you prefer that.



================
Comment at: llvm/test/Object/X86/yaml-elf-x86-rel-broken.yaml:4
 
+## TODO: Remove this test.
+
----------------
Maybe worth doing this first?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75608/new/

https://reviews.llvm.org/D75608





More information about the llvm-commits mailing list