[PATCH] D75647: [llvm-readobj] Include section name of notes.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5134
         continue;
-      PrintHeader(P.p_offset, P.p_filesz);
+      PrintHeader(None, P.p_offset, P.p_filesz);
       Error Err = Error::success();
----------------
Probably,

```
/*SecName=*/None
```


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:6278
+    if (SecName)
+      W.printString("Name", *SecName);
     W.printHex("Offset", Offset);
----------------
Should we always print fields? (i.e. print `Name=something` for `!SecName`).
Is it the only case for LLVM output where we can omit/print field I guess?
(I remember we had something like this before somewhere and removed it).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75647/new/

https://reviews.llvm.org/D75647