[PATCH] D75644: Test that volatile load type isn't changed
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 5 00:35:35 PST 2020
lebedev.ri added a comment.
Okay, thank you for the patch.
Langref changes seem to have gone AWOL.
This doesn't guarantee that we don't do such change elsewhere other than instcombine though.
================
Comment at: llvm/test/Transforms/InstCombine/volatile_load_cast.ll:4
+target datalayout = "e-p:64:64-i32:32:32-i64:64:64-f32:32:32-f64:64:64"
+
define float @float_load(i32* %addr) {
----------------
This needs a comment, something like
```
; See https://reviews.llvm.org/D75644 and https://reviews.llvm.org/D75505#inline-688817
; Don't ever change the type of `volatile`-loaded value, keep bitcast afterwards.
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75644/new/
https://reviews.llvm.org/D75644
More information about the llvm-commits
mailing list