[PATCH] D70606: LLD: CET shadow stack support on Windows
Petr Penzin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 4 21:45:17 PST 2020
penzn marked an inline comment as done.
penzn added a comment.
Another minor edit, I moved COFF test files for llvm-readobj to the directory where the rest of them are now.
In D70606#1904783 <https://reviews.llvm.org/D70606#1904783>, @ruiu wrote:
> LGTM with this change.
>
> As to how to test this, I'm fine with checking in a binary file until you extend yaml2obj so that the tool can produce an ExtendedDLLCharacterstics section. It isn't ideal but we already have a few binary files in our test suite.
Thank you! Made the change. I don't have commit rights, help with the merge will be greatly appreciated.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70606/new/
https://reviews.llvm.org/D70606
More information about the llvm-commits
mailing list