[PATCH] D75498: [llvm-objdump] Add option to sort symbols during disassembly

Wed Mar 4 16:53:32 PST 2020

stephenneuendorffer added a comment.

In D75498#1906660 <https://reviews.llvm.org/D75498#1906660>, @MaskRay wrote:

> In D75498#1906052 <https://reviews.llvm.org/D75498#1906052>, @stephenneuendorffer wrote:
>
> > > As I commented at https://reviews.llvm.org/D75498#1904244 , `some other linker disassembles symbols in alphabetical order` does not match what I have observed with GNU ld, gold and lld. Are you using a different linker or am I missing something?
> >
> > You're not missing anything.  The linker in question is not an open source linker.
>
>
> Shouldn't that linker be fixed instead? It is usually a simple data structure replacement... For example, `unordered_map` -> `begin`.
>
> Sorry that I will make some pushback here. A non-deterministic symbol order also affects other tools like readelf/nm. Fixing the linker is likely the simplest way to make every binary manipulation tool happy.

The short answer is no, we can't fix the other linker.   I don't mind the pushback and I don't mind if you say "We don't want this."  It's something that I'd rather not carry around internally, but maybe that's just what has to be done. :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75498/new/

https://reviews.llvm.org/D75498