[llvm] 75af9da - [MC][ELF] Error for sh_type, sh_flags or sh_entsize change

[Fāng-ruì Sòng via llvm-commits]

On Wed, Mar 4, 2020 at 4:37 PM Joerg Sonnenberger <joerg at bec.de> wrote:

> On Wed, Mar 04, 2020 at 04:25:36PM -0800, Fāng-ruì Sòng wrote:
> > It is already non-trivial to write assembly portable on x86-32 and x86-64
> >
> > .section .eh_frame,"a", at progbits # 32
> > .section .eh_frame,"a", at unwind # 64
> >
> > Writing .eh_frame manually does not seem very correct.
>
> So far, @progbits worked everywhere. Can't even find a test case in
> binutils for @unwind. As such, this seems to be a move in the wrong
> direction.
>
> Joerg
>

I don't agree. .eh_frame contents for x86-32 and x86-64 are different.
There is hardly any scenario where .eh_frame must be written in an assembly
file.
Writing @unwind is really a very small effort.

"Can't even find a test case in binutils for @unwind."  That 2004 commit is
to be blamed. There are still some tests, e.g.
gas/testsuite/gas/i386/x86-64-unwind.s and some X86_64_UNWIND readelf -S
tests.




-- 
宋方睿
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200304/a65c7860/attachment.html>