[PATCH] D75658: Add test comments about missing section names and only having file/offset

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht created this revision.
Herald added subscribers: llvm-commits, MaskRay, emaste.
Herald added a reviewer: espindola.
Herald added a reviewer: jhenderson.
Herald added a project: LLVM.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75658

Files:
  llvm/test/tools/llvm-readobj/ELF/gnu-notes.test


Index: llvm/test/tools/llvm-readobj/ELF/gnu-notes.test
===================================================================
--- llvm/test/tools/llvm-readobj/ELF/gnu-notes.test
+++ llvm/test/tools/llvm-readobj/ELF/gnu-notes.test
@@ -59,6 +59,7 @@
 # LLVM-NEXT:   }
 # LLVM-NEXT: ]
 
+## Note: there is no "Name: .note.gnu.build-id" assertion here because it is stripped.
 # LLVM-STRIPPED:      Notes [
 # LLVM-STRIPPED-NEXT:   NoteSection {
 # LLVM-STRIPPED-NEXT:     Offset: 0x78
@@ -72,6 +73,7 @@
 # LLVM-STRIPPED-NEXT:   }
 # LLVM-STRIPPED-NEXT: ]
 
+## Note: offset and length printed instead of "found in: .note.gnu.build-id" because it is stripped.
 #      GNU-STRIPPED:Displaying notes found at file offset 0x00000078 with length 0x00000020:
 # GNU-STRIPPED-NEXT:  Owner                Data size 	Description
 # GNU-STRIPPED-NEXT:  GNU                  0x00000010	NT_GNU_BUILD_ID (unique build ID bitstring)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75658.248354.patch
Type: text/x-patch
Size: 913 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200305/9340f842/attachment.bin>