[PATCH] D75305: [AIX] Handle LinkOnceODRLinkage and llvm.global_ctors/dtors' AppendingLinkage

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 4 15:17:13 PST 2020


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1596
 
+  if (isSpecialLLVMGlobalArrayForStaticInit(GV))
+    return;
----------------
Should there be a comment indicating why we are not emitting these? Would this be the place where we would add code to handle these instead of emitting them as arrays? In other words, should the comment be a TODO?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75305/new/

https://reviews.llvm.org/D75305





More information about the llvm-commits mailing list