[PATCH] D75291: Rename "llvm-gsym" and "llvm-gsymutil" to "gsymutil".
Francesco Petrogalli via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 4 15:11:23 PST 2020
fpetrogalli added a comment.
In D75291#1906405 <https://reviews.llvm.org/D75291#1906405>, @MaskRay wrote:
> In D75291#1904393 <https://reviews.llvm.org/D75291#1904393>, @fpetrogalli wrote:
>
> > Hello @clayborg ,
> >
> > this patch is breaking shared libs builds (`cmake path/to/llvm -DBUILD_SHARED_LIBS=ON`).
> >
> > Could you please fix it?
> >
> > Regards,
> >
> > Francesco
>
>
> `-DBUILD_SHARED_LIBS=ON` build is good.
Reverting this patch locally worked for me yesterday, so I assumed it was this patch causing the problem. When I pulled upstream today everything was working, so I must have done something wrong. In any case, thank you for double checking.
Francesco
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75291/new/
https://reviews.llvm.org/D75291
More information about the llvm-commits
mailing list